Open
Conversation
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/cli@0.0.47-pr.439.4472b1fPrefer not to change any import paths? Install using npm alias so your code still imports npm i "base44@npm:@base44-preview/cli@0.0.47-pr.439.4472b1f"Or add it to your {
"dependencies": {
"base44": "npm:@base44-preview/cli@0.0.47-pr.439.4472b1f"
}
}
Preview published to npm registry — try new features instantly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Description
This PR adds integration tests for media file handling in the
devcommand, covering both public and private file upload/serve flows. It also refactors thewaitForDevServerhelper into a shareddev-utils.tstestkit utility so it can be reused across test files.Related Issue
None
Type of Change
Changes Made
packages/cli/tests/cli/dev-media.spec.tswith two new integration tests:Core/UploadFile, verifies the returned URL, and fetches the file contentCore/UploadPrivateFile, obtains a signed URL viaCore/CreateFileSignedUrl, and validates access with valid token, wrong token (400 +InvalidJWT), and missing token (401 +Missing token)waitForDevServerfromdev.spec.tsintopackages/cli/tests/cli/testkit/dev-utils.tsto share it across test filesdev.spec.tsto importwaitForDevServerfrom the new shared locationTesting
npm test)Checklist
docs/(AGENTS.md) if I made architectural changesAdditional Notes
The
waitForDevServerrefactor also improves robustness by throwing an explicit error if the URL pattern is not found (instead of a non-null assertion).🤖 Generated by Claude | 2026-03-23 13:22 UTC